Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soundboard #1068

Open
wants to merge 45 commits into
base: feature/voice-channel-effect-send
Choose a base branch
from

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jul 3, 2023

Summary

discord/discord-api-docs#6260

Depends on #993, but can be separated easily - the two PRs can really be merged in any order.

  • As usual, naming is still tbd in a few places, but overall this PR is fully functional
  • The current implementation just uses application/octet-stream instead of trying to determine the correct mime type, which seems to be working fine; may want to improve that, though
    • This also means that sound.to_file() does not contain a file extension, unless it's a default sound (which already has the file extension in its name)
  • It's not entirely clear whether GUILD_SOUNDBOARD_SOUNDS_UPDATE contains the full list of sounds, or just a subset of modified ones

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 3, 2023
apparently soundboard audit logs always have `target_id = None`
@shiftinv shiftinv force-pushed the feature/soundboard branch 2 times, most recently from 926bcb4 to ddd948d Compare August 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

1 participant