Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INVITES_DISABLED guild feature #5269

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

advaith1
Copy link
Member

@advaith1 advaith1 commented Aug 3, 2022

No description provided.

@onerandomusername
Copy link
Contributor

Is there any documentation on how this behavior will work when this feature is enabled?

@Jupith
Copy link
Contributor

Jupith commented Aug 13, 2022

You'll still be able to fetch all invites, aswell as create them, just users trying to join via them will get an error.

@wasdennnoch
Copy link
Contributor

Does that also affect joining via discovery and lurking (or possibly even OAuth guilds.join) or is it purely restricted to invites?

@Jupith
Copy link
Contributor

Jupith commented Aug 14, 2022

It effects discovery yes, not sure about the scope.

@MinnDevelopment
Copy link
Contributor

Is it intentional that there is no audit log entry for disabling invites?

@shaydewael
Copy link
Contributor

I believe this is just an experiment right now

@shaydewael shaydewael added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Aug 27, 2022
@advaith1
Copy link
Member Author

it is out to all community servers as of today

@onerandomusername
Copy link
Contributor

onerandomusername commented Aug 27, 2022

The internal API validation for setting this feature is a bit incorrect, and I've just created 6 public update webhooks when setting BOTH community and invites_disabled features in the same api request. The backend creates the public update webhook but errors with a 403 on the invites_disabled feature as the community feature wasn't initally set. This in turn doesn't remove the public_updates webhook but doesn't save it as the webhook, either. Then another webhook is created on the next request (while debugging) and now I have six phantom webhooks.

Additionally, this feature can be set when disabling community which maybe be an additional bug which may or may not be related.

I'll create an issue for this since that would likely be easier to track.

@onerandomusername
Copy link
Contributor

Is it known if this has fully rolled out yet?

docs/resources/Guild.md Outdated Show resolved Hide resolved
@shaydewael
Copy link
Contributor

the feature is still being refined, but we should be good to publish the documentation at this point

Co-Authored-By: Shay DeWael <3411005+shaydewael@users.noreply.github.com>
@shaydewael shaydewael merged commit 776d658 into discord:main Sep 7, 2022
@shaydewael shaydewael removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Sep 7, 2022
@advaith1 advaith1 deleted the invites-disabled branch September 7, 2022 22:13
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Sep 11, 2022
itohatweb added a commit to twilight-rs/twilight that referenced this pull request Sep 16, 2022
Discord has added a new guild feature, which when enabled pauses all
invites, preventing new users from joining.

Reference: discord/discord-api-docs#5269
lukellmann added a commit to kordlib/kord that referenced this pull request Nov 18, 2022
 * InvitesDisabled:
   discord/discord-api-docs#5269

 * DeveloperSupportServer:
   discord/discord-api-docs#5572

 * ApplicationCommandPermissionsV2:
   discord/discord-api-docs#5649
lukellmann added a commit to kordlib/kord that referenced this pull request Nov 18, 2022
The added GuildFeatures are:

 * InvitesDisabled:
   discord/discord-api-docs#5269

 * DeveloperSupportServer:
   discord/discord-api-docs#5572

 * ApplicationCommandPermissionsV2:
   discord/discord-api-docs#5649

Editing GuildFeatures can for example be used to pause invites:
guild.edit {
    features = guild.features + GuildFeature.InvitesDisabled
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants