Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux 4.15 already ships the drm_file* #117

Closed
ghost opened this issue Feb 1, 2018 · 11 comments
Closed

Linux 4.15 already ships the drm_file* #117

ghost opened this issue Feb 1, 2018 · 11 comments

Comments

@ghost
Copy link

ghost commented Feb 1, 2018

...which means I'll have to apply this patch to make the bulid work. Please do some research on version numbers before adding these preprocessor checks.

diff --git a/module/evdi_connector.c b/module/evdi_connector.c
index 811b85a..69a98b9 100644
--- a/module/evdi_connector.c
+++ b/module/evdi_connector.c
@@ -85,7 +85,7 @@ static struct drm_encoder *evdi_best_single_encoder(struct drm_connector
        int enc_id = connector->encoder_ids[0];

        return drm_encoder_find(connector->dev,
-#if KERNEL_VERSION(4, 16, 0) <= LINUX_VERSION_CODE
+#if KERNEL_VERSION(4, 15, 0) <= LINUX_VERSION_CODE
                                 NULL,
 #endif
                                 enc_id);
@dawikur
Copy link

dawikur commented Feb 1, 2018

Yep, this is my typo, should be '4, 15' from the start.

@ghost
Copy link
Author

ghost commented Feb 1, 2018

How long would this take to be released in an updated displaylink driver package?

@ghost
Copy link
Author

ghost commented Feb 2, 2018

You can apply the patch yourself if you use any DKMS package, this module is built against the current kernel. It's simple enough, really.

@ghost
Copy link
Author

ghost commented Feb 2, 2018

It is easy. Just a pain to manage when you have over 200 Dell D1000 and a CTO shouting at you about "Spectre and Meltdown security concerns".

It'd be easier for my use case to have them bundled up.

@RyanNerd
Copy link

Sorry a bit of a c++ noob here. How the #@$%& do I get this to work with 4.15 kernel. No idea how to patch and I'd rather not build from source, but will if I need to.

@cacarr-pdxweb
Copy link

I'm with RyanNerd -- lost my secondary display with 4.15. Currently not pleased.

@3ach
Copy link

3ach commented Feb 19, 2018

Hi @RyanNerd and @cacarr-pdxweb -- I'm not sure which OS you're running, but I got it working on Arch by cloning the evdi-git repository from the AUR, adding the patch for PR #118 to the PKGBUILD, and then installing that. If either of you need more help doing that, I'd be happy to assist.

@RyanNerd
Copy link

Thanks @zachzundel I'm running Linux Mint 18.2. I got it working by thunking my kernel down to 4.14.19 and running the DisplayLink script while running on that kernel. The script executed without issues. On a whim I installed the new 4.15.4 kernel and for some reason DisplayLink worked without the need to run the script against the new kernel. I hope this helps you @cacarr-pdxweb
The main challenge I had was getting the nouveau drivers working (DisplayLink will not work with NVida's proprietary drivers) -- since every SO or other web page when searching for "nouveau" tell you how to disable it and not how to get the ^#$% nouveau driver to actually work -- I still have no idea how I got nouveau to start working...

@cacarr-pdxweb
Copy link

@zachzundel I'm running Antergos (which, not being vanilla Arch, probably tells you something about how not keen I am to patch this). Thanks for the assist offer -- I'll give it a spin at some point, and may hit you up if I find myself hopelessly confused. Right now I'm living with my fan going full blast half the time on the LTS kernel.

I'm still interested in @Unaccounted4 's question:

How long would this take to be released in an updated displaylink driver package?

@3ach
Copy link

3ach commented Feb 20, 2018

I don't think this is an issue with the displaylink package, but with the EVDI package, which DisplayLink depends on. There is already a PR that solves this issue, all that needs to happen is a maintainer merging that into master and then installing evdi-git from the AUR should fix it.

redjamesg pushed a commit to redjamesg/displaylink-debian that referenced this issue Feb 23, 2018
Since it seems it will take some time for the KERNEL_VERSION typo in evdi_connector.c DisplayLink/evdi#117 has made it's way to the mainstream branch, I have made a small hack in your install script to make this change on the fly.
@ghost
Copy link
Author

ghost commented May 16, 2018

Is this even related?

@ghost ghost closed this as completed May 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants