Governance Interface

[kayalight]

https://drive.google.com/file/d/1s2nJQ9jxri5XmdERTjUj9MvuxRtccKBP/view?usp=sharing

[creed-victor]

Notes

• We will not be preparing backend for it yet, so ignore username/pseudonym parts. Looks like hiding doesn't break anything, so I think it can be hidden.
• "Governance Proposals" table has filter for "active", "executed", "failed" and etc proposals - it may take a lot of time to implement so keep it for last.
• "Top Addresses" table - not sure if there is an easy way on retrieving that data without implementing backend, leave it for the end too.
• Dialog of proposal itself has extended description, it also would require backend so just keep description that is available in the contract. Though it would be nice to implement markdown parser - so links would be clickable now.

[kayalight]

feel free to reach out with questions

[pietro-maximoff]

1. hide links in header (trade/lend/etc). Later they should open in new tab and direct to live.sorvyn.app but dapp will have redesign so until actual paths not decided just hide it.
2. add voting delegation back, just add button somewhere with "delegate votes" which would open existing dialog (can be in header near wallet connection and visible when user is connected). Tzu should make design for that sometime. Implementation is on temp-governance branch.
3. hide top addresses and leaderboard - it needs work from backenders and database, not sure if we will have it this week (unless Betsy has free time)
4. Change dates to just blocknumbers for now, something was changed in contracts and now they dont give timestamps so frontend shows invalid date. Later may fix it when implementing backend.
5. Start implementing blockchain interactions to it
6. Hide username and other parts of UI if data is not yet retrievable from blockchain.
7. it would be great if it would support some kind of markdown or atleast would parse url's in description and make it clickable (with target=_blank)

done 1-7
all changes in this branch feature/newstyleUpdate

[kayalight]

@pietro-maximoff please only include the sip number and title, please loose the github link and sha from this

also please make the width of the form smaller inline with the design file also please make sure the colours are correct

[kayalight]

@creed-victor have you made backend aware of what you need to make this happen?
do you have an ETA of when this will be made?

Yes, it was discussed while on the call you introduced this design first time.
And still needs to be decided how it should be implemented.

until then can you please loose the github link and sha from the titles?

Entire title comes from blockchain contract. What was already written to blockchain can't be changed anymore.
Trying to parse title and showing only part of it (until first dot . for example) only would work with current proposals, because smart-contract doesn't enforce proposal description rules and anyone can create it - parsing is useless here because there is no way we will know and prepare it for all possible cases.
Workaround would be to show only first x characters of title and append it with ...
It's possible to remove hyperlink from github url.

So have you followed up with backend to make a decision of how it should be implemented?

It sounds like we should not be reading the title directly from the blockchain then?

[kayalight]

@pietro-maximoff please only include the sip number and title, please loose the github link and sha from this

please add the github button link and add the sha to the info section

please also make the addresses and transaction hash links to the exploer and coloured yellow

[kayalight]

Please use the correct font spacing (it seems too much space between letter) and font weights

@pietro-maximoff

[kayalight]

@pietro-maximoff please make sure test is correct weight and spacing

[kayalight]

@pietro-maximoff please create the info section as presented in the design

[kayalight]

@pietro-maximoff if you have issues finding the font information please let me know, it is all in the xd file

[kayalight]

@pietro-maximoff please remove this failed button

[kayalight]

@pietro-maximoff if you have any issues with any of these changes please reach out and contact me, otherwise I expect to see all these changes with the next push

[kayalight]

@pietro-maximoff what is happening here?

[creed-victor]

@pietro-maximoff please create the info section as presented in the design

@kayalight This is not possible to implement, we don't have this data in sips at all (it needs backend to be developed and governance doesn't have it yep).

Same with proposal title - we don't have it, the only thing we have is id (which is not same as SIP ID) and long description you see there.

[kayalight]

@creed-victor have you made backend aware of what you need to make this happen?
do you have an ETA of when this will be made?
this is not a 1 day interface and so should be pixel perfect

until then can you please loose the github link and sha from the titles?

[creed-victor]

@creed-victor have you made backend aware of what you need to make this happen?
do you have an ETA of when this will be made?

Yes, it was discussed while on the call you introduced this design first time.
And still needs to be decided how it should be implemented.

until then can you please loose the github link and sha from the titles?

Entire title comes from blockchain contract. What was already written to blockchain can't be changed anymore.
Trying to parse title and showing only part of it (until first dot . for example) only would work with current proposals, because smart-contract doesn't enforce proposal description rules and anyone can create it - parsing is useless here because there is no way we will know and prepare it for all possible cases.
Workaround would be to show only first x characters of title and append it with ...
It's possible to remove hyperlink from github url.

[pietro-maximoff]

i'll do pixel-perfect for all data that we have now

[kayalight]

@creed-victor have you made backend aware of what you need to make this happen?
do you have an ETA of when this will be made?

Yes, it was discussed while on the call you introduced this design first time.
And still needs to be decided how it should be implemented.

until then can you please loose the github link and sha from the titles?

Entire title comes from blockchain contract. What was already written to blockchain can't be changed anymore.
Trying to parse title and showing only part of it (until first dot . for example) only would work with current proposals, because smart-contract doesn't enforce proposal description rules and anyone can create it - parsing is useless here because there is no way we will know and prepare it for all possible cases.
Workaround would be to show only first x characters of title and append it with ...
It's possible to remove hyperlink from github url.

And did you follow up with backend to decide how it would be implemented?
when are you expecting to decide this?

it is obvious that perhaps we should be pulling the title from somewhere else then? what would you need to build for that?
perhaps the way a sip is entered could help solve this issue?

[kayalight]

@creed-victor this is not a 1 day interface so we do not need to make sacrifices

[creed-victor]

And did you follow up with backend to decide how it would be implemented?
when are you expecting to decide this?

Will see if we can add it to upcoming sprint.

it is obvious that perhaps we should be pulling the title from somewhere else then? what would you need to build for that?

Yes, it needs backend.

perhaps the way a sip is entered could help solve this issue?

Any user can enter / propose sip and there is no way we would be able to stop them from entering title incorrectly.

@creed-victor this is not a 1 day interface so we do not need to make sacrifices

This is not sacrifice, only pastering things until required data is retrievable

[kayalight]

@creed-victor
i wanted to ask james to change the proposal struct to have different fields for title, link, hash, description and did not do it
i can ask if we still have sufficient time for the change (we don not have)
alternatively we can just interpret the string accordingly
by parsing it on the frontend
and loading the content from the url
either way, we probably won't have it on v1

[kayalight]

And did you follow up with backend to decide how it would be implemented?
when are you expecting to decide this?

Will see if we can add it to upcoming sprint.

it is obvious that perhaps we should be pulling the title from somewhere else then? what would you need to build for that?

Yes, it needs backend.

perhaps the way a sip is entered could help solve this issue?

Any user can enter / propose sip and there is no way we would be able to stop them from entering title incorrectly.

@creed-victor this is not a 1 day interface so we do not need to make sacrifices

This is not sacrifice, only pastering things until required data is retrievable

Thank you for explaining this to me

[pietro-maximoff]

@pietro-maximoff what is happening here?

#14 (comment) -
see step 4

[pietro-maximoff]

@pietro-maximoff please make sure test is correct weight and spacing

fixed, please check

[pietro-maximoff]

@pietro-maximoff please remove this failed button

done, and also i cut the title to two lines, so please check

[pietro-maximoff]

Please use the correct font spacing (it seems too much space between letter) and font weights

@pietro-maximoff

fixed