Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for performance #136

Merged
merged 7 commits into from
Jan 11, 2022
Merged

improvements for performance #136

merged 7 commits into from
Jan 11, 2022

Conversation

creed-victor
Copy link
Collaborator

@creed-victor creed-victor commented Dec 8, 2021

  • use rpc nodes instead of ws where possible
  • moved proposal details from modal to dedicated page (prevents downloading data from other proposals)
  • fixes progress bar image (it respects % now)

task: https://taiga.sovryn.app/project/sovryn-light/task/673

also added some info about current state and requirements of voting:

Screenshot 2021-12-10 at 14 52 01

task: https://taiga.sovryn.app/project/sovryn-light/task/652

@creed-victor creed-victor added bug Something isn't working enhancement New feature or request labels Dec 8, 2021
@creed-victor creed-victor self-assigned this Dec 8, 2021
@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 8, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72c88d1
Status: ✅  Deploy successful!
Preview URL: https://fa905305.bitocracy.pages.dev

View logs

src/app/containers/BlockChainProvider/saga.ts Outdated Show resolved Hide resolved
src/app/containers/ProposalRow/index.tsx Outdated Show resolved Hide resolved
src/app/containers/ProposalRow/index.tsx Outdated Show resolved Hide resolved
src/app/containers/ProposalRow/index.tsx Outdated Show resolved Hide resolved
@Alitasovryn
Copy link

Screen Shot 2021-12-10 at 9 18 53 AM

@Alitasovryn
Copy link

Works fine

Copy link
Contributor

@soulBit soulBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, proposals load almost 2x faster now 😄

I made two small updates - renamed Quarums -> QuorumDetails, and styling for new details to match the rest of the page content

@soulBit soulBit mentioned this pull request Dec 20, 2021
17 tasks
@creed-victor creed-victor merged commit fd729fb into development Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants