Getting properties throws NullReferenceException

[peschkaj]

When getting properties on an incorrectly named bucket, CorrugatedIron throws a NullReferenceException. Riak is returning a 404. CorrugatedIon should return a more polite error message instead of falling down and crying.

RiakBucketProperties bucketProperties = new RiakBucketProperties();
bucketProperties.SetNVal(4);
bucketProperties.SetSearch(true);
bucketProperties.SetAllowMultiple(true);
bucketProperties.SetWVal("all");
bucketProperties.SetRVal("quorum");
if (!client.SetBucketProperties("buyseasons/products", bucketProperties).IsSuccess)
{
    Console.WriteLine("Setting bucket properties failed");
}
// boom goes the dynamite
RiakResult<RiakBucketProperties> riakBuckpropertiesResult = client.GetBucketProperties("buyseasons/products", true);

[OJ]

It's worth noting that this changeset includes code which deliberately stops bucket property setting and getting if the bucket contains a forward slash. URL encoding this doesn't have any affect on the issue, so there's no point in relying on that.

Instead, we just reject it and say it's invalid. If we don't, then the interaction with Riak is not what you would expect. Hence this is why I decided to do this.

Thoughts?

[peschkaj]

worksforme

---

Jeremiah Peschka - Founder, Brent Ozar Unlimited
MCITP: SQL Server 2008, MVP
Cloudera Certified Developer for Apache Hadoop

On Thu, Feb 7, 2013 at 5:21 PM, OJ Reeves notifications@github.com wrote:

It's worth noting that this changeset includes code which deliberately
stops bucket property setting and getting if the bucket contains a forward
slash. URL encoding this doesn't have any affect on the issue, so there's
no point in relying on that.

Instead, we just reject it and say it's invalid. If we don't, then the
interaction with Riak is not what you would expect. Hence this is why I
decided to do this.

Thoughts?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/71#issuecomment-13272383.

[OJ]

OK, I might just close this issue then. We'll get this out in the next release.