-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair broken tests with matplotlib 3.3 #1090
Merged
rebeccabilbro
merged 15 commits into
DistrictDataLabs:develop
from
rebeccabilbro:mpl-3.3
Aug 6, 2020
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e4b76cf
mpl 3.3 has a number of API changes that broke visual tests, particul…
rebeccabilbro 0c1f5e2
bump test req for mpl
rebeccabilbro d4669b1
revert test rcmod
rebeccabilbro b6c61d7
this image is broken too
rebeccabilbro 97d9117
bumping tols to see if these will pass on travis for vanilla python 3.6
rebeccabilbro 503a88b
bump tols for miniconda
rebeccabilbro e003922
fix missing import
rebeccabilbro 2fe1af3
one more tol bump for appveyor disperson plot
rebeccabilbro 04ae2d9
fix meta and rcmod tests
bbengfort 7ca66fc
reset baseline images after rcparams ignore
bbengfort 123d221
reverting some images and tols to see if they were actually necessary…
rebeccabilbro 5971bb9
some of the tols were necessary
rebeccabilbro 864ded9
test 1 to resolve appveyor miniconda timeouts by updating image to Vi…
rebeccabilbro 4229b0c
test 2 - revert to Previous Visual Studio 2017 and instead downgrade …
rebeccabilbro 11e8454
removing miniconda from appveyor test matrix because the tests hang i…
rebeccabilbro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-3.52 KB
(91%)
tests/baseline_images/test_cluster/test_elbow/test_quick_method.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.35 KB
(94%)
...baseline_images/test_features/test_manifold/test_manifold_classification_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.83 KB
(92%)
tests/baseline_images/test_features/test_manifold/test_manifold_single_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.73 KB
(93%)
tests/baseline_images/test_features/test_pca/test_biplot_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.68 KB
(93%)
tests/baseline_images/test_features/test_pca/test_scale_false_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.32 KB
(93%)
tests/baseline_images/test_features/test_pca/test_scale_true_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1019 Bytes
(100%)
tests/baseline_images/test_features/test_projection/test_3d_continuous_plot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.79 KB
(94%)
tests/baseline_images/test_features/test_projection/test_discrete_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.35 KB
(120%)
tests/baseline_images/test_meta/test_random_visualizer_not_close.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# Library Dependencies | ||
matplotlib>=3.2.1 | ||
matplotlib>=3.3 | ||
scipy>=1.0.0 | ||
scikit-learn>=0.20 | ||
numpy>=1.13.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebeccabilbro did a lot of work regenerating baseline images for binning, class balance, feature correlation, dispersion plot, freqdist, postag, and tsne - but somehow adding these lines to the exclude function managed to revert them to their original state (well fingers crossed, it worked on my MacBook, but not sure about CI). The changes seemed to be related to grid lines and bar colors.
current working hypothesis - we were setting one of these values unintentionally and as a result, matplotlib was ignoring all of our styles, by excluding them, the styles work as expected?
But you know … that's just a hypothesis, I really have no clue what is actually happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebeccabilbro I did build the docs and everything was fine - and the figures generated by the plot directive were as I expected, RE grid lines and colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still flummoxed by this … 🤷