Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module factory #2434

Merged
merged 24 commits into from
Feb 17, 2019
Merged

Module factory #2434

merged 24 commits into from
Feb 17, 2019

Conversation

filrak
Copy link
Collaborator

@filrak filrak commented Feb 13, 2019 •
edited
Loading

Related issues

closes #2418
closes #2406

TODO:

  • refactor other modules
  • move list of registered modules to factory
  • update docs

I also made a minor refactor of module.ts and splitted the types out of it

@patzick patzick changed the base branch from develop to master February 13, 2019 19:39
@patzick patzick changed the base branch from master to develop February 13, 2019 19:39
pkarw
pkarw approved these changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, however, it still requires some additional work to refactor all modules we have in the core, correct?

@filrak
Copy link
Collaborator Author

filrak commented Feb 14, 2019

yup

@filrak filrak requested a review from patzick February 15, 2019 15:44
@filrak
Copy link
Collaborator Author

filrak commented Feb 15, 2019

ok just docs to be updated. @patzick you can review the code

patzick
patzick requested changes Feb 16, 2019
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks cool generally.
To go further we need upgrade notes and changelog also :)

core/lib/module/index.ts Outdated Show resolved Hide resolved
@filrak
Copy link
Collaborator Author

filrak commented Feb 16, 2019

@patzick changelog and uprgade notes ready ;)

@filrak filrak changed the title WIP: Module factory Module factory Feb 16, 2019
@filrak filrak merged commit 8a68a38 into vuestorefront:develop Feb 17, 2019
@filrak filrak added this to the 1.9 milestone Feb 17, 2019
@patzick patzick modified the milestones: 1.9, 1.8.3 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkarw pkarw pkarw approved these changes

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filrak @pkarw @patzick