Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#2450 show prices after adding product to cart in offline mode #2510

Conversation

@patzick
Copy link
Collaborator

commented Feb 27, 2019

Related issues

closes #2450

Short description and why it's useful

Shows regular price when there is no totals from server.

I also discovered, that cart summary is in cart.state.platformTotalSegments which is updated after response from server, so after adding new product summary still was not updated. So i made a reactive online helper and used it in getter which returns cart summary.

New Vue.observable is pretty cool! 馃挜 :)

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

@patzick patzick requested review from filrak and pkarw Feb 27, 2019

core/helpers/index.ts Show resolved Hide resolved
@filrak
filrak approved these changes Feb 27, 2019
@pkarw
pkarw approved these changes Feb 27, 2019

@patzick patzick merged commit 85d985b into DivanteLtd:develop Feb 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patzick patzick deleted the patzick:bugfix/#2450-show-prices-after-adding-product-to-cart-in-offline-mode branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.