Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/location client 2.1 #30

Merged
merged 2 commits into from
Sep 6, 2016
Merged

Conversation

ameenross
Copy link
Collaborator

No description provided.

@ameenross
Copy link
Collaborator Author

@danslo, I'd appreciate a confirmation from you that this works

@danslo
Copy link
Contributor

danslo commented Sep 6, 2016

I'm a little occupied at the moment to do extensive testing, however:

$ php bin/magento postnl:location:get --postal-code=3192AK | head -n5
Country: NL
Street: In de Fuik 47
City: Hoogvliet Rotterdam
Zip: 3192HD
Remark: Dit is een Postkantoor. Post en pakketten die u op werkdagen vóór de lichtingstijd afgeeft, bezorgen we binnen Nederland de volgende dag.

Patched install:

$ curl -O https://patch-diff.githubusercontent.com/raw/DivideBV/Postnl/pull/30.diff
$ patch -p1 < 30.diff

And I get identical output. Looks good to me. 👍

@ameenross
Copy link
Collaborator Author

Thanks

@ameenross ameenross merged commit a40a0cd into master Sep 6, 2016
@ameenross ameenross deleted the feature/location-client-2.1 branch September 26, 2016 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants