Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/post&tag #60

Merged
13 commits merged into from
Apr 27, 2018
Merged

Feature/post&tag #60

13 commits merged into from
Apr 27, 2018

Conversation

r26zhao
Copy link
Member

@r26zhao r26zhao commented Apr 26, 2018

这个pr主要做了以下修改:

  1. 去掉了postdetailserializer里的get_replies方法,因为现在replies通过 /posts/{id}/replies/获取
  2. 优化了postdetailserializer里的get_participants_count方法,之前写的太复杂了>-<
  3. 还有indexpostserializer里的 get_latest_reply_time
  4. postviewset 里的 popular action, 原来我写的只返回前10条 --> queryset[: 10], 现在queryset是48小时内所有热门帖子,然后paginator的page_size 改成了10

另外 select_related 和 prefetch_related 我没怎么用过,不知道如何优化 = =

@r26zhao r26zhao requested review from a user, rinka0414 and tinyx April 26, 2018 15:22
@r26zhao
Copy link
Member Author

r26zhao commented Apr 26, 2018

哎= =? 怎么25号之前的commit还在。。

@coveralls
Copy link

coveralls commented Apr 26, 2018

Pull Request Test Coverage Report for Build 66

  • 25 of 26 (96.15%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 83.001%

Changes Missing Coverage Covered Lines Changed/Added Lines %
posts/serializers.py 3 4 75.0%
Totals Coverage Status
Change from base Build 64: 0.7%
Covered Lines: 1665
Relevant Lines: 2006

💛 - Coveralls

@ghost ghost merged commit cd2f15f into dev Apr 27, 2018
@ghost ghost deleted the feature/post&tag branch April 27, 2018 12:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants