Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating timezone instructions #87

Merged
merged 2 commits into from
Aug 4, 2014
Merged

Conversation

OctoKatie
Copy link
Contributor

Updated timezone instructions to be generic. From DjangoGirls Australia.

updated timezone instructions to be generic.
@@ -48,7 +48,9 @@ Let's ignore the other files for now - we won't change them. The only thing to r

Let's make some changes in `mysite/settings.py`.

It would be nice to have the correct time on our website. You should find lines that contain `USE_TZ` and `TIME_ZONE` and modify them to look like this:
It would be nice to have the correct time on our website. Go to http://en.wikipedia.org/wiki/List_of_tz_database_time_zones and copy your relevant TZ. (eg. `Europe/Berlin` )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would spell out "timezone" completely (or is it "time zone"?) instead of using the abbreviation "TZ".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I used TZ was because this is the name of the column used in the Wikipedia page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good point.
I'm just worried about introducing too much jargon, especially to
non-native speakers.
What do you think about "copy your relevant time zone (TZ)"?
On Aug 4, 2014 9:53 AM, "Katie" notifications@github.com wrote:

In django_start_project/README.md:

@@ -48,7 +48,9 @@ Let's ignore the other files for now - we won't change them. The only thing to r

Let's make some changes in mysite/settings.py.

-It would be nice to have the correct time on our website. You should find lines that contain USE_TZ and TIME_ZONE and modify them to look like this:
+It would be nice to have the correct time on our website. Go to http://en.wikipedia.org/wiki/List_of_tz_database_time_zones and copy your relevant TZ. (eg. Europe/Berlin )

The reason I used TZ was because this is the name of the column used in
the Wikipedia page.


Reply to this email directly or view it on GitHub
https://github.com/DjangoGirls/tutorial/pull/87/files#r15744001.

Updating time zone instructions
bmispelon added a commit that referenced this pull request Aug 4, 2014
Updating timezone instructions
@bmispelon bmispelon merged commit 5624144 into DjangoGirls:master Aug 4, 2014
@bmispelon
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants