Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to point to raphael.amd.js #986

Merged

Conversation

dpogue
Copy link
Contributor

@dpogue dpogue commented Aug 11, 2015

Fix for being able to use Raphaël with browserify.

Fix for being able to use raphael with browserify.
@tomasAlabes
Copy link
Collaborator

raphael.js is still the main file... the no-deps and amd files are other ways to consume it.

@dpogue
Copy link
Contributor Author

dpogue commented Aug 11, 2015

Unfortunately, that means when you're using browserify and you say require('raphael') it tries to load the main raphael.js file that isn't CommonJS compatible.

@tomasAlabes
Copy link
Collaborator

I did some research and I guess adding the amd version as main is the correct decision, as npm packages are consumed like that...
Setting it as main. If we are missing something, we'll see.

@tomasAlabes tomasAlabes reopened this Aug 18, 2015
tomasAlabes added a commit that referenced this pull request Aug 18, 2015
Update package.json to point to raphael.amd.js
@tomasAlabes tomasAlabes merged commit 8139c0b into DmitryBaranovskiy:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants