New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature skip_preload #34
Conversation
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
4 similar comments
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
Pull Request Test Coverage Report for Build 250
💛 - Coveralls |
|
The SELECT "posts".* FROM "posts" WHERE "posts"."user_id" IN (1, 2)
or
SELECT "posts".* FROM "posts" WHERE "posts"."user_id" IN (?, ?) [["user_id", 1], [user_id", 2]] |
I think your README update is incomplete/broken... |
Very much your remind. I'm so sorry, ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OuYangJinTing, thank you for the PR!
I've requested some minor changes, and please add yourself to the changelog.
Also, thanks @PikachuEXE for taking a lead on the review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank for this gem and all contributors. This gem is great, auto-preload config is convenient.
But sometimes we don’t need to loads all records association auto matically, just load AR own associations.
This PR is trying to deal with this scene.