This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Updating deprecated method and some cleanup. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weerd
requested review from
katiecrane and
DFurnes
and removed request for
a team
DFurnes
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This pull request updates the
ForceHttps.phpmiddleware to remove the deprecatedLeague\Uri\Schemes\Httpclass and useLeague\Uri\Httpinstead.After the recent Laravel upgrade to 5.6, our Aurora Dev & QA instances have been borked and running into a redirect loop of sorts. We suspect it's due to the upgrades leading to the full deprecation of the above class and associated method we utilized. Updating to the new class should solve the issue. 🤞
Also does a little cleanup to ensure it applies the middleware to all non-local instances, and adds a debug logging statement for help in future troubleshooting.
How should this be reviewed?
👀
Relevant tickets
References Pivotal #172383668.
Checklist