Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended Homestead release & Phoenix PHP version. #19

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Oct 1, 2018

This pull request updates to suggest the latest Homestead release that I've tested on my local, PHP version for Phoenix (see DoSomething/phoenix-next#1121), and updates the suggested default PHP CLI to be PHP 7.2.

@DFurnes DFurnes requested a review from weerd October 1, 2018 16:21
@@ -20,12 +20,12 @@ $ cd ~/Code
$ git clone git@github.com:laravel/homestead.git homestead
```

Check out the [`v7.12.0` tag](https://github.com/laravel/homestead/releases) of Homestead. We'll periodically test newer releases and update these directions.
Check out the [`v7.17.0` tag](https://github.com/laravel/homestead/releases) of Homestead. We'll periodically test newer releases and update these directions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈 moving on up!

Copy link
Contributor

@weerd weerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DFurnes DFurnes merged commit 223e8ec into master Oct 1, 2018
@DFurnes DFurnes deleted the version-updates branch October 1, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants