Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Menus #6

Open
edsu opened this issue Dec 22, 2016 · 2 comments
Open

Update Menus #6

edsu opened this issue Dec 22, 2016 · 2 comments

Comments

@edsu
Copy link
Member

edsu commented Dec 22, 2016

The app menu items should point to the Hydrator homepage on GitHub and display other relevant information about the app.

@machawk1
Copy link
Contributor

machawk1 commented Jan 4, 2017

Related, the first item in the About menu on macOS using the provided binary says, "About ElectronReact". I believe https://github.com/DocNow/hydrator/blob/master/app/main.development.js#L112 is where the value resides. I would submit a PR but cannot build and test per #9.

@machawk1
Copy link
Contributor

As of the v0.0.5 release (perhaps before), the app's name is in the app menu on macOS:

Screen Shot 2020-04-21 at 10 50 29 AM

Maybe some context should be provided to University of Maryland, e.g., copyright: "Copyright © 2020 University of Maryland" in electron-builder.yml?

For providing additional data about the app, you might also consider the approach from @N0taN3rd's Electron version of WAIL:
Screen Shot 2020-04-21 at 10 56 17 AM
...implemented here.

I am still hunting around for an Electron app that specifies URL in the about window if the single option in the menu is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants