Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRE-1448] Update github-flow-manager to check github actions by workflow name #10

Merged
merged 10 commits into from
Mar 11, 2022

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented Mar 9, 2022

After being using github-flow-manager for testing the checks of a repository that is using the Gitub Actions for testing and build & Push, we have discover that it's necessary check in different way when the check is from a Github Action that for example an Azure DevOps pipeline or CircleCI, due with the actual way is checking the Github Action job names instead of the Github Action workflow.

There are introduced some changes to be able to get the necessary attributes to check if there is a GitHub Action or not, also it's necessary reorganize the type githubQuery to GithubQuery and refactoring with individual types to be able to use that types in specific functions.

Also was added github actions for check linters and pre-commit configuration

@xoanmm xoanmm requested review from lupiuz and alv91 March 9, 2022 17:29
@xoanmm xoanmm self-assigned this Mar 9, 2022
@xoanmm xoanmm requested a review from mknet3 March 9, 2022 17:31
@xoanmm xoanmm force-pushed the feature/change-way-check-github-actions branch 2 times, most recently from 4259464 to bf773aa Compare March 10, 2022 17:32
@xoanmm xoanmm marked this pull request as draft March 10, 2022 17:46
@xoanmm xoanmm marked this pull request as ready for review March 10, 2022 17:46
@xoanmm xoanmm added the enhancement New feature or request label Mar 10, 2022
@xoanmm xoanmm force-pushed the feature/change-way-check-github-actions branch from d15d2b7 to bb9f3c1 Compare March 10, 2022 18:15
@xoanmm xoanmm changed the title feat: change way of check github actions using specific attributes [SRE-1448] Update github-flow-manager to check github actions by workflow name Mar 11, 2022
@xoanmm xoanmm merged commit 789780c into master Mar 11, 2022
@xoanmm xoanmm deleted the feature/change-way-check-github-actions branch March 11, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants