Skip to content

Commit

Permalink
Fix checking convert success
Browse files Browse the repository at this point in the history
Don't look at the error string, as deprecation warnings will also come
through on this string. Only look at if the command was successful.
  • Loading branch information
bfcoder committed May 13, 2019
1 parent afbc03c commit d783334
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/libreconv.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def convert
*command,
unsetenv_others: true
)
unless status.success? && error == ''
if !status.success?
raise ConversionFailedError,
"Conversion failed! Output: #{output.strip.inspect}, " \
"Error: #{error.strip.inspect}"
Expand Down

0 comments on commit d783334

Please sign in to comment.