Use a binary accumulator in QuotedPrintable encoder to reduce memory usage #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I noticed huge memory usage when encoding big emails (~15MB, that big mainly because of someone's huge base64-encoded inline image in their mail signature) after investigation, I found that currently the code builds a list of small binaries, reverses and joins it. As per the Erlang Efficiency Guide, appending to binaries is well optimized and should perform better.
I also confirmed the functions can be tail-call optimized the way they're written currently, with returning
if
expressions (at least on newest OTP 25).Similarly to #86 , here is the benchmark used and results:
Results: