Only install ember-cli-shims if it doesn't exist #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check first to see if ember-cli-shims is installed as a package (which it is after ember-cli 2.11.
rtablada
reviewed
Jun 13, 2017
| afterInstall: function() { | ||
| return this.addBowerPackageToProject('ember-cli-shims', '~0.1.1'); | ||
| afterInstall: function(options) { | ||
| if (!('ember-cli-shims' in options.project.addonPackages)) { |
There was a problem hiding this comment.
Maybe change this to using indexOf to support legacy node?
There was a problem hiding this comment.
addonPackages is an object with each package as a key and I think the in operator for a key of an object works all the way back to ES3. I'm willing to be wrong about that though - just let me know.
|
Forgot it was an object. You're right! LGTM!
…--
Ryan Tablada
On June 13, 2017 at 4:15:04 PM, Jonathan Johnson ***@***.***) wrote:
***@***.**** commented on this pull request.
------------------------------
In blueprints/ember-composable-helpers/index.js
<#270 (comment)>
:
> @@ -1,7 +1,9 @@
module.exports = {
normalizeEntityName: function() {},
- afterInstall: function() {
- return this.addBowerPackageToProject('ember-cli-shims', '~0.1.1');
+ afterInstall: function(options) {
+ if (!('ember-cli-shims' in options.project.addonPackages)) {
addonPackages is an object with each package as a key and I think the in
operator for a key of an object works all the way back to ES3. I'm willing
to be wrong about that though - just let me know.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACaipLyHcxjd0hFgZ6owGYvDOp_mmEisks5sDvvYgaJpZM4NgJ85>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Check first to see if ember-cli-shims is installed as a package (which
it is after ember-cli 2.11.
Closes #254
Some caveats:
optionsparameter I used to detect the installation ofember-cli-shims- passing it in is part of the API docs at https://ember-cli.com/api/classes/Blueprint.html but there are no details.