Embroider

[alias-mac]

Changes proposed in this pull request

Use @embroider/test-setup

Ember addons benefit on using this addon provided by embroider directly.
Read more information about it here.

Fix warnings provided by embroider build:

While running ember try:one embroider-safe or ember try:one embroider-optimized you will see warnings during the build:

    WARNING in /private/var/folders/1m/cqqx124s5gj0dn95jmbp91p0000mgw/T/embroider/a0a719/node_modules/ember-data/node_modules/ember-inflector/index.js 4:0-48
    "export 'defaultRules' was not found in './lib/system'
     @ ./assets/dummy.js
    
    WARNING in ./helpers/entries.js 1:0-60
    "export 'entries' was not found in '../../../helpers/entries'
     @ ./assets/dummy.js
    
    WARNING in ./helpers/from-entries.js 1:0-69
    "export 'fromEntries' was not found in '../../../helpers/from-entries'
     @ ./assets/dummy.js
    
    WARNING in ./helpers/pick.js 1:0-54
    "export 'pick' was not found in '../../../helpers/pick'
     @ ./assets/dummy.js
    
    WARNING in ./helpers/values.js 1:0-58
    "export 'values' was not found in '../../../helpers/values'
     @ ./assets/dummy.js

The ones related with this addon are fixed (in the second commit).

I had to rename keys to entries to match the expectation in app/ re-export, but this can be considered a breaking change, so perhaps it will be better to change the re-export to be keys instead of entries, although that breaks the convention from the other re-exports. Open to suggestions on how you want to proceed here.

[alias-mac]

This is related with #403 but I took a different approach (since I'm not removing the re-exports).

[snewcomer]

@alias-mac Thanks for this PR! I'm fine either way. Would you mind merging in the main branch and see what happens to the test suite?

#404

[alias-mac]

@snewcomer rebased and ran the tests locally and they pass, but they are failing in CI.

I was able to reproduce it when I run it with CI=true environment too locally. After a bit of experimentation I was able to confirm that it is due to the fact that we test against IE11 in CI. When I remove that it passes.

Based on embroider's changelog it seems that IE11 is supported. I'll try to take a stab at it and see what might be needed to get this fixed, but open to ideas.

[alias-mac]

@snewcomer I synced with @rwjblue and he pointed me in the right direction on what was needed to make this pass.
The addon blueprint will contain new options by default, so I just added them here.
The test-setup function should probably support that by default, but for now this solves the problem.

Let me know what are the next steps to get this in. Thanks!

[snewcomer]

Woop woop!

[rwjblue]

@snewcomer any chance for a release with this one?