Add a inline registration strategy #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Sep 15, 2017
|
|
||
| indexHtml = indexHtml.replace('ESW_INLINE_PLACEHOLDER', swRegistration); | ||
|
|
||
| fs.writeFileSync(path.join(this.outputPath, 'index.html'), indexHtml); |
There was a problem hiding this comment.
This will force index.html to be re-rewitten for every rebuild. This breaks things like css hot-reloading (which is a built in feature of ember-cli) because it forces all rebuilds to modify the HTML itself (css hot-reloading requires a CSS file only change after the rebuild).
I'd suggest caching here to avoid writing the file on every rebuild (e.g. if the contents have not changed, don't write to it).
There was a problem hiding this comment.
Hi Rob, do you have a handy link demonstrating how to add caching to such a thing?
ghost
force-pushed
the
inline-registration
branch
from
7b603e5
to
b2806fc
Compare
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67