Reconfigure prefer-destructuring rule

This reconfigures the rule to not require destructuring for arrays. Also, removes custom implementation to just use the one provided by eslint.
DockYard · Jul 27, 2018 · 7736f83 · 7736f83
1 parent 6e03edd
commit 7736f83
Show file tree

Hide file tree

Showing 10 changed files with 6 additions and 106 deletions.
diff --git a/config/recommended.js b/config/recommended.js
@@ -18,7 +18,7 @@ module.exports = {
     'no-var': 'error',
     'no-useless-rename': 'error',
     'object-shorthand': ['error', 'always'],
-    'prefer-destructuring': 'error',
+    'prefer-destructuring': ['error', { array: false, object: true }, { enforceForRenamedProperties: false }],
     'prefer-spread': 'error',
     'prefer-template': 'error',
     'eol-last': ['error', 'always'],

diff --git a/lib/rules/prefer-destructuring.js b/lib/rules/prefer-destructuring.js
diff --git a/tests/fixtures/prefer-destructuring/bad/example.js b/tests/fixtures/prefer-destructuring/bad/example.js
@@ -0,0 +1 @@
+let foo = SomeThing.foo;
diff --git a/...ject-destructuring/bad/direct-property.js → ...structuring/bad/object-direct-property.js b/...ject-destructuring/bad/direct-property.js → ...structuring/bad/object-direct-property.js
diff --git a/...ject-destructuring/bad/nested-property.js → ...structuring/bad/object-nested-property.js b/...ject-destructuring/bad/nested-property.js → ...structuring/bad/object-nested-property.js
diff --git a/...ject-destructuring/bad/string-property.js → ...structuring/bad/object-string-property.js b/...ject-destructuring/bad/string-property.js → ...structuring/bad/object-string-property.js
diff --git a/...uire-object-destructuring/good/example.js → ...ures/prefer-destructuring/good/example.js b/...uire-object-destructuring/good/example.js → ...ures/prefer-destructuring/good/example.js
@@ -1,4 +1,3 @@
-/* eslint-disable prefer-destructuring */
 let { foo } = SomeThing;
 let { bar } = SomeThing.Baz;
 
@@ -8,4 +7,7 @@ const { get } = SomeThing;
 const { set } = SomeThing;
 
 const { val } = SomeThing['some.key'];
-/* eslint-enable prefer-destructuring */
+
+let arr = [1, 2, 3, 4];
+let [one] = arr;
+let alsoOne = arr[0];
diff --git a/tests/fixtures/require-array-destructuring/bad/array-in-object-property.js b/tests/fixtures/require-array-destructuring/bad/array-in-object-property.js
diff --git a/tests/fixtures/require-array-destructuring/bad/simple-array.js b/tests/fixtures/require-array-destructuring/bad/simple-array.js
diff --git a/tests/fixtures/require-array-destructuring/good/example.js b/tests/fixtures/require-array-destructuring/good/example.js