Closes #2043

[fakenickels]

You can not define Materialize with window.Materialize because Meteor package export won't be able to export the variable.
Tell me if I have to do some changes before merging :).

[fakenickels]

One more thing, for Meteor developers, it's better to add uncompressed assets in packages due two things:

1. Better to debug.
2. Meteor compresses assets automatically for us.

So I take the freedom to replace bin/materialize.js by dist/js/materialize.js.

[lampe]

+1

[JulianKingman]

+1

[nelreina]

+1

[Crenshinibon]

+1

[serkandurusoy]

@grsabreu while at it, would you mind also updating package.js to support the new addAsset directive? Because otherwise, this package won't build.

// Check if we are post Meteor@1.2 with which api.addFiles() throws error requiring api.addAssets()
var assetDirective = api.addAssets === undefined ? 'addFiles' : 'addAssets';

// Add material design icons
api[assetDirective]([
  'dist/font/material-design-icons/Material-Design-Icons.eot',
  'dist/font/material-design-icons/Material-Design-Icons.svg',
  'dist/font/material-design-icons/Material-Design-Icons.ttf',
  'dist/font/material-design-icons/Material-Design-Icons.woff',
  'dist/font/material-design-icons/Material-Design-Icons.woff2'
], 'client');

// Add roboto bold font
api[assetDirective]([
  'dist/font/roboto/Roboto-Bold.ttf',
  'dist/font/roboto/Roboto-Bold.woff',
  'dist/font/roboto/Roboto-Bold.woff2'
], 'client');

// Add roboto light font
api[assetDirective]([
  'dist/font/roboto/Roboto-Light.ttf',
  'dist/font/roboto/Roboto-Light.woff',
  'dist/font/roboto/Roboto-Light.woff2'
], 'client');

// Add roboto medium font
api[assetDirective]([
  'dist/font/roboto/Roboto-Medium.ttf',
  'dist/font/roboto/Roboto-Medium.woff',
  'dist/font/roboto/Roboto-Medium.woff2'
], 'client');

// Add roboto regular font
api[assetDirective]([
  'dist/font/roboto/Roboto-Regular.ttf',
  'dist/font/roboto/Roboto-Regular.woff',
  'dist/font/roboto/Roboto-Regular.woff2'
], 'client');

// Add roboto thin font
api[assetDirective]([
  'dist/font/roboto/Roboto-Thin.ttf',
  'dist/font/roboto/Roboto-Thin.woff',
  'dist/font/roboto/Roboto-Thin.woff2'
], 'client');

// Add css and javascript
api.addFiles([
  'dist/css/materialize.css',
  'dist/js/materialize.js'
 ], 'client');

[fakenickels]

@serkandurusoy fakenickels@add48e4
I did that :)

[serkandurusoy]

Hah, I had not realised you've already done it, and even more properly :)

[dcworldwide]

:+1

[bkuri]

👍

[0o-de-lally]

+1 @Dogfalo can we merge it?

[brokenseal]

👍

[brokenseal]

New line? :P

[fakenickels]

Oh, it's true! I'll add one!

[dandv]

Yes, the package should include the _un_minified .js file.

[Dogfalo]

Thank you everyone for finding out the problem. I do not do much meteor development and so I am grateful for your help.

[fakenickels]

Nice one, @Dogfalo!
When the new version will be published to Atmosphere?

[methodbox]

Yes, please! I am eager to get this rolled into my app with the fix. Thank you @grsabreu. There are many breaking changes with Meteor 1.2.x, and this is actually a common one.

@Dogfalo, if your packaging anything else for Meteor, this should be a consideration.

[Dogfalo]

If you want to grab updates before release you can see what I wrote here to use a github repo as a meteor package #2171

[PolGuixe]

+1 for new release to be rolled to Atmosphere.

[donwojtallo]

+1