Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure sass imports #5175

Closed
wants to merge 1 commit into from
Closed

Restructure sass imports #5175

wants to merge 1 commit into from

Conversation

tomscholz
Copy link
Contributor

  • Moved variables and normalize outside the components folder, since they just are not components.

@tomscholz
Restructure sass folder
ec730e3 
- Moved variables and normalize outside the components folder, since they just are not components.
@tomscholz tomscholz changed the title Restructure sass folder Restructure sass imports Sep 7, 2017
@flexbox
Copy link

flexbox commented Oct 30, 2017 •
edited
Loading

The actual version of Normalize.css is 7.0.0

@tomscholz Do you think we can bump it on the same PR?

@DanielRuf
Copy link
Contributor

Imo this should be integrated with npm and an import rule, not in our sass folder.

@flexbox
Copy link

flexbox commented Oct 30, 2017 •
edited
Loading

Totally agreed!

But Maybe there are some custom rule'z like in this file js/date_picker/picker.date.js

@DanielRuf
Copy link
Contributor

Which rules do you mean?

@flexbox
Copy link

flexbox commented Oct 30, 2017

Just watched the history, And I think we can bump the version directly from the npm registry 🚀

@tomscholz
Copy link
Contributor Author

normalize has been updated to 7.0 in the v1 505ff79

@tomscholz tomscholz closed this Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomscholz @flexbox @DanielRuf