Bug fix expandable functionality in collapsible. #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mode is expandable click event can directly pass to the open collapsible, rather than entire collapsible. If we do not do that way - for even number of collapsible expandable does not work.
|
I'm not sure what bug youre fixing. Youre saying that even number of collapsibles don't work? I've tried that and it seems to work for me. |
|
Did you try for "expandable" option or "accordion" ? - Please note issue is for "expandable" I just committed a small test-change in collapsible.html --- you can see preview here: http://htmlpreview.github.io/?https://github.com/snow01/materialize/blob/master/collapsible.html Try to expand the expandable there - last one on the page. |
Dogfalo
added a commit
that referenced
this pull request
Jan 31, 2015
Bug fix expandable functionality in collapsible.
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mode is expandable click event can directly pass to the open collapsible, rather than entire collapsible. If we do not do that way - for even number of collapsible expandable does not work. Change is small - changed from$this to $ (this)