chore: Bump React to v17 and Reactist to v12 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlovegrove
requested review from
jankratochvilcz
and removed request for
a team
scottlovegrove
requested review from
frankieyan
and removed request for
jankratochvilcz and
proxi
frankieyan
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @frankieyan:
This is needed in order to bring Reactist v12 to Todoist and Twist, as well as extensions-renderers.
I don't have permissions to this repo so working off a fork for now.
One thing I couldn't figure out is that React v16 is still pulled down by
@testing-library/react-hooks@7and@testing-library/react@12, even though both have React listed as<18.0.0under peerDependencies. This causes tests to end up with two copies of React and fail. I'll have to take another look tonight.Reference
https://github.com/Doist/reactist/releases/tag/v12.0.1
https://github.com/Doist/reactist/releases/tag/v12.0.0