Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security module #12041

Closed
nicolas-friot opened this issue Oct 4, 2019 · 0 comments
Closed

Security module #12041

nicolas-friot opened this issue Oct 4, 2019 · 0 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@nicolas-friot
Copy link

There is an large bug in the security module. When you choose a personal password generation mode, it is possible to choose a minimal repetition for same character equal to 0. Then the password module configuration is completely blocked.

It should be a good idea to check the minimal value equal to 1 in the Dolibarr interface.

To solute the problem, i had the following line at the beginning of the public function consecutiveInterationSameCharacter($password) in the class « modGeneratePassPerso.class.php » 👍

if ($this->NbRepeat == 0 ) $this->NbRepeat=1;

Thank you to integrate this perspective.

Best regards

@nicolas-friot nicolas-friot added the Bug This is a bug (something does not work as expected) label Oct 4, 2019
eldy added a commit that referenced this issue Oct 7, 2019
…-password

[fix #12041] - Generate password mode perso
eldy added a commit that referenced this issue Oct 7, 2019
@eldy eldy closed this as completed in c8fb817 Oct 7, 2019
eldy added a commit that referenced this issue Oct 7, 2019
…-password

[Fix #12041] - validate the 0 as min value consecutive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

1 participant