Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Extend option ORDER_ADD_ORDERS_WITH_PARENT_PROD_IF_INCDEC for all virtual product stats (renamed into PRODUCT_STATS_WITH_PARENT_PROD_IF_INCDEC) #11094

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

altairis-tof
Copy link
Contributor

also replace constant ORDER_ADD_ORDERS_WITH_PARENT_PROD_IF_INCDEC by new constant PRODUCT_STATS_WITH_PARENT_PROD_IF_INCDEC

@altairis-tof
Copy link
Contributor Author

@eldy @atm-maxime i did not understand why Travis build failed

@jtraulle
Copy link
Member

There was 1 failure:

1) UserTest::testUserCreate
Failed asserting that 0 is less than -3.

/home/travis/build/Dolibarr/dolibarr/test/phpunit/UserTest.php:140

@jtraulle jtraulle added the PR to fix - Continuous Integration Test failed The PHP unit tests return something wrong with our code. Check the details to know what to fix. label Sep 10, 2019
@jtraulle
Copy link
Member

@altatof Can you merge current develop branch into your PR branch to see if this issue was not caused by something else that has now been fixed ?

@altairis-tof
Copy link
Contributor Author

@jtraulle done and ready for merge ;-)

@jtraulle jtraulle removed the PR to fix - Continuous Integration Test failed The PHP unit tests return something wrong with our code. Check the details to know what to fix. label Oct 4, 2019
@jtraulle jtraulle assigned eldy and unassigned altairis-tof Oct 4, 2019
@jtraulle jtraulle requested a review from eldy October 4, 2019 09:19
@eldy eldy changed the title harmonize product stats for product components Extend option ORDER_ADD_ORDERS_WITH_PARENT_PROD_IF_INCDEC for all virtual product stats (renamed into PRODUCT_STATS_WITH_PARENT_PROD_IF_INCDEC) Oct 8, 2019
@eldy eldy changed the title Extend option ORDER_ADD_ORDERS_WITH_PARENT_PROD_IF_INCDEC for all virtual product stats (renamed into PRODUCT_STATS_WITH_PARENT_PROD_IF_INCDEC) NEW Extend option ORDER_ADD_ORDERS_WITH_PARENT_PROD_IF_INCDEC for all virtual product stats (renamed into PRODUCT_STATS_WITH_PARENT_PROD_IF_INCDEC) Oct 8, 2019
@eldy eldy merged commit 653958b into Dolibarr:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants