Add autoselect optional parameter to select_produits #11496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jul 13, 2019
| @@ -1891,9 +1891,10 @@ public function select_dolusers_forevent($action = '', $htmlname = 'userid', $sh | |||
| * 'warehouseclosed' = select products from closed warehouses, | |||
| * 'warehouseinternal' = select products from warehouses for internal correct/transfer only | |||
| * @param array $selected_combinations Selected combinations. Format: array([attrid] => attrval, [...]) | |||
| * @param int $autoselect Autoselect option for Ajax Product select | |||
There was a problem hiding this comment.
Can you confirm this feature means "Automatic selection if just one value" ? If yes, please change comment so we can understand difference between param "autoselect" and "selected"
eldy
reviewed
Jul 13, 2019
| @@ -187,9 +188,9 @@ | |||
|
|
|||
| $form = new Form($db); | |||
| if (empty($mode) || $mode == 1) { // mode=1: customer | |||
| $arrayresult = $form->select_produits_list("", $htmlname, $type, 0, $price_level, $searchkey, $status, $finished, $outjson, $socid, '1', 0, '', $hidepriceinlabel, $warehouseStatus); | |||
| $arrayresult = $form->select_produits_list("", $htmlname, $type, $limit, $price_level, $searchkey, $status, $finished, $outjson, $socid, '1', 0, '', $hidepriceinlabel, $warehouseStatus); | |||
There was a problem hiding this comment.
It seems the PR contains change from another PR.
eldy
added
the
PR to fix or conflict to solve
|
It seems this PR was set with "Discussion" or "PR to fix" tag, but no answer nor correction was provided since a long time. So request is automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Add optional Autoselect parameter for Select_produits
Add optional Autoselect parameter for Select_produits for used in ajax product select call.