The constant ACCOUNTING_ENABLE_EXPORT_DRAFT_JOURNAL is deprecated #12754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darkjeff I know that you rely on this feature. Are you ok to valide its removal ? If not, can you describe the use case when you need it to argue to keep it for @aspangaro |
eldy
added
the
PR waiting more user feedbacks
|
@eldy No I am not ok with this removal. Draft Journal is a very nice feature. And it's very important for the first accounting export. My 2 cents |
|
In my defense, this type of export does not respect the type of export chosen and is only available on sales and purchases, not on expense reports . For a better follow up, you should not keep this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.