Fix #16423 can attach email AND use email template #16477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#Fix Dolibarr#16423 Dolibarr#16420 clear_attached__files should be lauch only on init form.
daraelmin
changed the title
daraelmin
force-pushed
the
daraelmin-patch-2
branch
from
ea01c4a
to
5fddbc5
Compare
daraelmin
changed the title
|
I've tested 3a19cbb and the mail attachment works as expected. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Fix #16423 #16420
clear_attached__files should be lauch only on init form. Otherwise it will clear all attachés mail while using template.
@eldy I'm not sure, so I didn'remove it completely, but I don't see why we test if the mailmodel parameter is set with alpha before clearing the list of attached files (and renew the session).