Fix #16423 V13 can join file AND use mail template #16488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Feb 28, 2021
| @@ -330,7 +330,7 @@ public function get_form($addfileaction = 'addfile', $removefileaction = 'remove | |||
| $langs->loadLangs(array('other', 'mails')); | |||
|
|
|||
| // Clear temp files. Must be done at beginning, before call of triggers | |||
| if (GETPOST('mode', 'alpha') == 'init' || (GETPOST('modelmailselected', 'alpha') && GETPOST('modelmailselected', 'alpha') != '-1')) | |||
| if (GETPOST('mode', 'alpha') == 'init' && (GETPOST('modelmailselected', 'alpha') && GETPOST('modelmailselected', 'alpha') != '-1')) | |||
There was a problem hiding this comment.
Don't understand why a &. Doing that means the list of files will no more be clean whe we call the page with param mode = 'init'
There was a problem hiding this comment.
I was unsure of that, but, on "init" shouldn't the "modelmailselected" unset or set to 0 or -1 ?
There was a problem hiding this comment.
Actually the list is cleared each time the mailmodelselected parameter is not set to "-1" wich is very strange to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Fix #16423 can not attach email when using templatein formmail
#Fix #16420 can not use email templae un formmail