NEW API can receive documents #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Dec 12, 2016
|
|
||
| require_once DOL_DOCUMENT_ROOT . '/core/lib/files.lib.php'; | ||
|
|
||
| if (!DolibarrApiAccess::$user->rights->ecm->upload) { |
There was a problem hiding this comment.
To fix security, we must enhance this to use
dol_check_secure_access_document( )
to check if user has permission on module related to where file is uploaded using the "modulepart" value (this is job of method).
Problem: this method currently can be used to test user has permission to read, but not permission to write. We must also add a parameter to test on ->write instead of ->lire
eldy
added
PR OK to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.