Make the result class a MutableMapping

[Rafiot]

This way, you can also use .get('key') on the parsed result.

[coveralls]

Coverage decreased (-0.008%) to 99.659% when pulling 098449a on Rafiot:MutableMapping into 36e4761 on DomainTools:master.

[coveralls]

Coverage decreased (-0.008%) to 99.659% when pulling 098449a on Rafiot:MutableMapping into 36e4761 on DomainTools:master.

[Rafiot]

Fails on Python 2.x... trying out a bunch of stuff.

[Rafiot]

Okay, I'm not sure I understand what _items is supposed to do.

The main reason I wanted to make Results a collections.MutableMapping is because it makes the class a real dict and also gives me a get method. I could implement this one manually, but having Results a dictionary would be very nice and more generic.
Can you have a look, please?

[timothycrosley]

Hi @Rafiot,

I like what you are trying to accomplish here! I think some of the confusion comes from the fact that the base result object is intended to be interacted with not only as a dictionary but as a list in several cases. Additionally, in 3.5+ the location of the base collection objects has changed. I've put together a pull request here: https://github.com/DomainTools/python_api/pull/8/files#diff-0a50901a753def4eb9add20ff0f9817bL1 that I believe accomplishes what you are after.

Thanks!

~Timothy

[Rafiot]

Hi @timothycrosley,

Yep, it does exactly what I wanted to do, thanks!

Raphaël

[timothycrosley]

Awesome! I've going ahead and pushed out version 0.1.5 to PYPI with this improvement in place.

Thanks!

~Timothy

[Rafiot]

Excellent, I'm going to use it in the misp-modules: MISP/misp-modules#75