fix #860 calling setLabel(String label) removes required indicator

DominoKit · Oct 26, 2023 · a34f0eb · a34f0eb
1 parent a1a0fbd
commit a34f0eb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/AbstractFormElement.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/AbstractFormElement.java
@@ -20,6 +20,7 @@
 
 import elemental2.dom.HTMLElement;
 import elemental2.dom.HTMLFieldSetElement;
+import elemental2.dom.Text;
 import java.util.*;
 import java.util.function.Function;
 import java.util.stream.Collectors;
@@ -93,6 +94,8 @@ public abstract class AbstractFormElement<T extends AbstractFormElement<T, V>, V
   private boolean focusValidationPaused = false;
   private boolean emptyAsNull;
 
+  private Text labelText = text();
+
   protected V defaultValue;
   private boolean showRequiredIndicator = true;
 
@@ -107,6 +110,7 @@ public AbstractFormElement() {
                         .addCss(dui_field_body)
                         .appendChild(wrapperElement = div().addCss(dui_input_wrapper)));
     labelElement = LazyChild.of(label().addCss(dui_field_label), formElement);
+    labelElement.whenInitialized(() -> labelElement.element().appendChild(labelText));
     messagesWrapper = LazyChild.of(div().addCss(dui_messages_wrapper), bodyElement);
     helperTextElement = LazyChild.of(span().addCss(dui_field_helper), messagesWrapper);
     errorElementSupplier =
@@ -375,7 +379,8 @@ public String getHelperText() {
    */
   @Override
   public T setLabel(String label) {
-    labelElement.get().setTextContent(label);
+    labelElement.get();
+    labelText.textContent = label;
     return (T) this;
   }