Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModalDialog Footer elements are cut off if modal-content exceeds screen height #811

Closed
bschmelcher opened this issue Aug 10, 2023 · 0 comments
Closed

ModalDialog Footer elements are cut off if modal-content exceeds screen height #811

bschmelcher opened this issue Aug 10, 2023 · 0 comments
Assignees
@vegegoku
Labels
bug Something isn't working version 1.x.x Version 1.x.x issues version 2.x.x Version 2.x.x issues
Projects
Domino UI
Milestone
1.0.2

Comments

@bschmelcher
Copy link

Describe the bug
Because modalDialogs do not start at the very top of the viewport (top is set to 30), the maxHeight calculation of modals should take that into account.
Currently, the footer elements will be cut off if the modal-content exceeds the screen height.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://demo.dominokit.org/components/modals
  2. Click on MODAL - DEFAULT SIZE
  3. Edit the Lorem ipsum content so it exceeds the viewport height
  4. See error

Expected behavior
Footer elements should not be cut off

Screenshots
image
@vegegoku vegegoku self-assigned this Aug 27, 2023
@vegegoku vegegoku added the bug Something isn't working label Aug 27, 2023
@vegegoku vegegoku added this to To do in Domino UI via automation Aug 27, 2023
@vegegoku vegegoku added the version 1.x.x Version 1.x.x issues label Aug 27, 2023
@vegegoku vegegoku modified the milestones: 2.0.0-RC2, 1.0.2 Aug 27, 2023
@vegegoku vegegoku added the version 2.x.x Version 2.x.x issues label Sep 11, 2023
@vegegoku vegegoku changed the title ModalDialog: Footer elements are cut off if modal-content exceeds screen height ModalDialog Footer elements are cut off if modal-content exceeds screen height Sep 11, 2023
vegegoku added a commit that referenced this issue Sep 11, 2023
@vegegoku
fix #811 ModalDialog Footer elements are cut off if modal-content exc…
f75c2a9 
…eeds screen height
vegegoku added a commit that referenced this issue Sep 11, 2023
@vegegoku
fix #811 ModalDialog Footer elements are cut off if modal-content exc…
bbe0436 
…eeds screen height
Domino UI automation moved this from To do to Done Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegegoku vegegoku

Labels
bug Something isn't working version 1.x.x Version 1.x.x issues version 2.x.x Version 2.x.x issues
Projects
Domino UI
  
Done
Milestone
1.0.2
Development

No branches or pull requests
2 participants
@vegegoku @bschmelcher