Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed source code structure to Cobra-based application structure #5

Merged
merged 1 commit into from
Aug 31, 2020
Merged

changed source code structure to Cobra-based application structure #5

merged 1 commit into from
Aug 31, 2020

Conversation

amir-shiati
Copy link
Member

No description provided.

@BaseMax
Copy link
Member

BaseMax commented Aug 31, 2020 •
edited

Run markdownlint '**/*.md' --ignore node_modules

CODE_OF_CONDUCT.md:70:81 MD013/line-length Line length [Expected: 80; Actual: 87]
CONTRIBUTING.md:5 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:11 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:17 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:23 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:29 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:35 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:41 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
CONTRIBUTING.md:45:81 MD013/line-length Line length [Expected: 80; Actual: 141]
CONTRIBUTING.md:46:81 MD013/line-length Line length [Expected: 80; Actual: 144]
README.md:20 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
README.md:56:81 MD013/line-length Line length [Expected: 80; Actual: 195]
##[error]Process completed with exit code 1.

Please review this. @jbampton

https://github.com/DonyaOS/PackageManager/actions/runs/232607647

@BaseMax
Copy link
Member

BaseMax commented Aug 31, 2020

Thanks Amir, Merged.

@BaseMax BaseMax merged commit 1e8e37e into DonyaOS:master Aug 31, 2020
@BaseMax BaseMax requested a review from jbampton August 31, 2020 12:17
@BaseMax BaseMax mentioned this pull request Aug 31, 2020
Open
@amir-shiati
Copy link
Member Author

amir-shiati commented Aug 31, 2020 via email

jbampton
jbampton reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BaseMax the .markdownlint.yml got deleted

@jbampton
Copy link
Contributor

And go.mod got deleted too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbampton jbampton jbampton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amir-shiati @BaseMax @jbampton