-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-2162] Handle '=' in secret values #216
Conversation
Not sure why this is failing, I'm unable to run the $ make test-e2e
./tests/e2e.sh
INFO: Executing 'secrets-download-fallback' tests
Doppler Error: The fallback file does not exist
ERROR: 'secrets-download-fallback' tests failed during execution
INFO: Completed 'secrets-download-fallback' tests
make: *** [test-e2e] Error 1``` |
Do the tests pass when you run this without your changes? |
locally, no |
Can you squash these commits into one? |
@Piccirello done |
Can you also cleanup the commit message a bit, just so that users have a bit more context when the see the line-item in their terminal. Something like "Fix handling of values containing '=' when setting secrets". |
Done
…On Wed, May 19, 2021 at 4:16 PM Tom Piccirello ***@***.***> wrote:
Can you also cleanup the commit message a bit, just so that users have a
bit more context when the see the line-item in their terminal. Something
like "Fix handling of values containing '=' when setting secrets".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#216 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAELFOCRV7AJ2WAHR5UK4FTTOQMCBANCNFSM44WK6PAA>
.
|
I think you picked up a couple additional commits in the process. You can likely fix this with a rebase: |
Should handle '=' appearing inside secret values.
Noticed another issue that prevents setting two secrets at once: https://linear.app/doppler/issue/ENG-2257/doppler-cli-doesnt-support-setting-two-secrets-at-once