ENG-4564: Require dopplersecret resources to be in operator namespace #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanoogian
commented
Aug 5, 2022
| @@ -6,6 +6,7 @@ require ( | |||
| github.com/go-logr/logr v0.3.0 | |||
| github.com/onsi/ginkgo v1.14.1 | |||
| github.com/onsi/gomega v1.10.2 | |||
| golang.org/x/sys v0.0.0-20220804214406-8e32c043e418 // indirect | |||
nmanoogian
commented
Aug 5, 2022
| @@ -100,7 +100,7 @@ build: generate fmt vet ## Build manager binary. | |||
| go build ${GO_BUILD_VERSION_FLAGS} -o bin/manager main.go | |||
|
|
|||
| run: manifests generate fmt vet ## Run a controller from your host. Does not use VERSION flags. | |||
| go run ./main.go | |||
| POD_NAMESPACE=doppler-operator-system go run ./main.go | |||
Piccirello
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the operator would process
dopplersecretresources in any namespace, effectively allowing token secrets to be read and managed secrets to be updated in any namespace in the cluster. This pattern is unintuitive and inconsistent with the Kubernetes RBAC rules. This PR requires alldopplersecretresources to be in the same namespace as the operator deployment (doppler-operator-systemby default) in order to be reconciled.Closes #21