Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/debug/internal/core: build broken on darwin since at least 2021-10-28 #49219

Closed
bcmills opened this issue Oct 29, 2021 · 12 comments
Closed

x/debug/internal/core: build broken on darwin since at least 2021-10-28 #49219

bcmills opened this issue Oct 29, 2021 · 12 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2021

greplogs --dashboard -md -l -e '//go:linkname must refer to declared function or variable'

2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-10_14
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-10_15
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-11_0
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-nocgo
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-arm64-11_0-toothrot
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-10_14
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-10_15
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-11_0
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-nocgo
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-arm64-11_0-toothrot
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-10_14
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-10_15
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-11_0
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-nocgo
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-arm64-11_0-toothrot
2021-10-28T18:10:59-26ed8fd-ed475fe/darwin-amd64-10_14
2021-10-28T17:52:59-26ed8fd-3124968/darwin-amd64-11_0
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-10_14
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-10_15
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-11_0
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-nocgo
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-arm64-11_0-toothrot
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-10_14
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-11_0
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-nocgo
2021-10-28T15:55:26-26ed8fd-61536ec/darwin-amd64-11_0
2021-10-28T15:35:25-26ed8fd-278b9b3/darwin-amd64-11_0
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-10_14
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-10_15
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-11_0
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-arm64-11_0-toothrot
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-10_14
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-10_15
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-11_0
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-nocgo
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-arm64-11_0-toothrot
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-10_14
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-10_15
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-11_0
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-nocgo
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-arm64-11_0-toothrot
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-10_14
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-10_15
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-11_0
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-arm64-11_0-toothrot
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-10_14
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-10_15
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-11_0
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-nocgo
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-arm64-11_0-toothrot
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-10_14
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-10_15
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-11_0
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-nocgo
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-arm64-11_0-toothrot

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 29, 2021
@bcmills bcmills self-assigned this Oct 29, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

This is a release blocker for Go 1.18 via #11811. (CC @golang/release)

@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

The fix (in CL 359596) appears to be to upgrade the dependency on x/sys.

@bcmills bcmills added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Oct 29, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/359596 mentions this issue: all: upgrade x/sys to latest

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/359595 mentions this issue: all: update go.mod to go 1.17

gopherbot pushed a commit to golang/debug that referenced this issue Nov 1, 2021
For golang/go#49219

Change-Id: Ia0ede89fcf365c3feef9d34ac5a6b379749c015e
Reviewed-on: https://go-review.googlesource.com/c/debug/+/359595
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@marwan-at-work
Copy link
Contributor

@bcmills 👋🏼

I just ran into the above error when trying out go1.18beta1 running this program: https://go.dev/play/p/PVYJTCGE7ZU

Let me know if this is a well known/fixed bug given the CLs mentioned, or if we should re-open this issue. Thanks!

@AbhimanyuAryan
Copy link

AbhimanyuAryan commented Apr 2, 2022

looks like this is not fixed in go1.18 darwin/arm64

bykof/go-plantuml#11

@bcmills
Copy link
Contributor Author

bcmills commented Apr 8, 2022

@AbhimanyuAryan, you may need to upgrade your x/debug and/or x/sys dependency to pick up the fix.

@AbhimanyuAryan
Copy link

Yes I fixed it thanks

XCiber added a commit to devopsext/tools that referenced this issue Apr 15, 2022
- Get rid of URL option and use default slack API url.
- Add Token and Channels options
- rename post method to postBody
- move token from query params to header
- render channels param for files.upload from options
- add .idea to gitignore
- upgrade golang.org/x/sys version due to build fail golang/go#49219
TrilokGeer pushed a commit to TrilokGeer/installer that referenced this issue Sep 14, 2022
Needed to bump x/sys dependency due to golang/go#49219
to ensure Go 1.18 compatibility on darwin.

This commit revendors our AzureStack fork to bring in:
openshift/terraform-provider-azurestack#5

which updated x/sys with the following commands:

go get -u golang.org/x/sys
go mod tidy -compat=1.17 && go mod vendor
StevenACoffman pushed a commit to 99designs/gqlgen that referenced this issue Sep 17, 2022
This picks up a new 2022 version of golang.org/x/sys which is caused by
golang/go#49219 and is needed to fix building
using Go 1.18 on aarch64-darwin.
skeeto added a commit to skeeto/passphrase2pgp that referenced this issue Sep 22, 2022
Older versions of the transitive dependency golang.org/x/sys cannot be
built on newer versions of Go for certain platforms.

golang/go#49219
joshua-goldstein added a commit to dgraph-io/ristretto that referenced this issue Oct 10, 2022
## Problem
 
Build was failing on darwin/arm64. See
[here](golang/go#49219).

## Solution

We update the dependency on x/sys.

```
> go get -u golang.org/x/sys
go: downloading golang.org/x/sys v0.0.0-20221010170243-090e33056c14
go: upgraded golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f => v0.0.0-20221010170243-090e33056c14
> go mod tidy
```
urandom2 added a commit to urandom2/ep that referenced this issue Nov 8, 2022
There is a blocking go bug on darwin, golang/go#49219, that was hit
during NixOS/nixpkgs#200068. While we are updating things it seems
reasonable to bump everything.
@siennathesane
Copy link

@bcmills would it be possible to create a new tag for golang.org/x/sys to make it easier for users to resolve this problem with go get -u?

siennathesane added a commit to siennathesane/bbolt that referenced this issue Nov 21, 2022
Upgraded golang.org/x/sys from v0.2.0 to account for golang/go#49219.

Signed-off-by: Sienna Lloyd <sienna@linux.com>
@heschi
Copy link
Contributor

heschi commented Nov 21, 2022

@mxplusb I tagged sys about 3 weeks ago, so I don't know what problem you're trying to solve but it's probably not this issue. sys will be tagged again in another couple weeks if that does turn out to be what you need.

astromechza pushed a commit to fnproject/cli that referenced this issue Dec 13, 2022
This picks up a new 2022 version of golang.org/x/sys and is needed to fix building
using Go 1.18 on aarch64-darwin which is caused by
golang/go#49219.
genshen added a commit to genshen/wssocks that referenced this issue Jan 22, 2023
…nc to fix building error

bump the two packages version to fix building error in go 1.18 (see:
https://stackoverflow.com/a/71508032/10068476 and golang/go#49219)
genshen added a commit to genshen/wssocks that referenced this issue Jan 22, 2023
…nc to fix building error

bump the two packages version to fix building error in go 1.18 on darwin (see:
https://stackoverflow.com/a/71508032/10068476 and golang/go#49219)
r4f4 pushed a commit to r4f4/terraform-providers that referenced this issue Oct 22, 2023
Needed to bump x/sys dependency due to golang/go#49219
to ensure Go 1.18 compatibility on darwin.

This commit revendors our AzureStack fork to bring in:
openshift/terraform-provider-azurestack#5

which updated x/sys with the following commands:

go get -u golang.org/x/sys
go mod tidy -compat=1.17 && go mod vendor
r4f4 pushed a commit to r4f4/terraform-providers that referenced this issue Oct 24, 2023
Needed to bump x/sys dependency due to golang/go#49219
to ensure Go 1.18 compatibility on darwin.

This commit revendors our AzureStack fork to bring in:
openshift/terraform-provider-azurestack#5

which updated x/sys with the following commands:

go get -u golang.org/x/sys
go mod tidy -compat=1.17 && go mod vendor
@golang golang locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Development

No branches or pull requests

8 participants