Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added functionality to mark users as churned #4

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

added functionality to mark users as churned #4

wants to merge 6 commits into from

Conversation

vivek-kumar-pandey
Copy link
Contributor

Please complete the following steps and check these boxes before filing your PR:

DostEducation/RP_IVR_analytics#363

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

Creating the feature for fetching the churned users and marking them churned

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.

@vivek-kumar-pandey vivek-kumar-pandey self-assigned this Mar 28, 2023
GauravGusain98
GauravGusain98 requested changes Mar 30, 2023
View reviewed changes
Copy link

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, please check

api/models/user.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
api/services/rapid_pro_services/update_user_group.py Outdated Show resolved Hide resolved
api/services/rapid_pro_services/update_user_group.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users.py Outdated Show resolved Hide resolved
GauravGusain98
GauravGusain98 requested changes Apr 3, 2023
View reviewed changes
Copy link

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions, please check

api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
api/services/rapid_pro_services/update_user_group_service.py Outdated Show resolved Hide resolved
GauravGusain98
GauravGusain98 requested changes Apr 5, 2023
View reviewed changes
Copy link

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
api/services/rapid_pro_services/update_user_group_service.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
api/services/rp_ivr_system_services/churn_users_service.py Outdated Show resolved Hide resolved
GauravGusain98
GauravGusain98 approved these changes Apr 5, 2023
View reviewed changes
Copy link

@GauravGusain98 GauravGusain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GauravGusain98 GauravGusain98 GauravGusain98 approved these changes

@Satendra-SR Satendra-SR Awaiting requested review from Satendra-SR

Assignees

@vivek-kumar-pandey vivek-kumar-pandey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vivek-kumar-pandey @GauravGusain98