Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1009 conflicts with SA1024 on C# 9 records inheritance #3248

Closed
wiciok opened this issue Nov 20, 2020 · 0 comments · Fixed by #3260
Closed

SA1009 conflicts with SA1024 on C# 9 records inheritance #3248

wiciok opened this issue Nov 20, 2020 · 0 comments · Fixed by #3260
Assignees
@sharwell
Labels
bug c# 9 fixed
Milestone
1.2.0-beta.304

Comments

@wiciok
Copy link

wiciok commented Nov 20, 2020 •
edited
Loading

Inheritance on positional records in single line causes SA1009:
image

Removing space, as suggested by SA1009 causes SA1024 to appear:
image

Only form not causing any warning is with inheritance statement moved to next line:
image
I assume that enforcing this style is not an expected behavior of SA1009 and SA1024, and SA1009 should be fixed to include such case.

Version: StyleCop.Analyzers.Unstable 1.2.0.261
@sharwell sharwell self-assigned this Dec 5, 2020
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Dec 5, 2020
@sharwell
Fix SA1009 handling of record inheritance
847d8f0 
Fixes DotNetAnalyzers#3248
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Dec 5, 2020
@sharwell
Fix SA1009 handling of record inheritance
e2a09f2 
Fixes DotNetAnalyzers#3248
@sharwell sharwell mentioned this issue Dec 5, 2020
Merged
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 5, 2020
@sharwell sharwell mentioned this issue Mar 23, 2023
Closed
@sharwell sharwell mentioned this issue Jan 9, 2024
Closed
@bjornhellander bjornhellander mentioned this issue Jan 10, 2024
Closed
@sharwell sharwell mentioned this issue Feb 9, 2024
Closed
@bjornhellander bjornhellander mentioned this issue May 7, 2024
Closed
@sharwell sharwell mentioned this issue May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
bug c# 9 fixed
Projects
None yet
Milestone
1.2.0-beta.304
Development

Successfully merging a pull request may close this issue.

Fix SA1009 handling of record inheritance sharwell/StyleCopAnalyzers
2 participants
@sharwell @wiciok