Move literals into resources #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxtn
force-pushed
the
resx
branch
10 times, most recently
from
324295e
to
1624f4c
Compare
sharwell
requested changes
Sep 23, 2019
There was a problem hiding this comment.
@NextTurn Thanks for the attention to detail here. I noticed some other issues with the strings, but I don't want to make any of those changes in this large pull request. The only changes I was looking for are related directly to the changes in this pull request, including the specific comments.
StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1503BracesMustNotBeOmitted.cs
Outdated
Show resolved
Hide resolved
...Analyzers/StyleCop.Analyzers/LayoutRules/SA1507CodeMustNotContainMultipleBlankLinesInARow.cs
Outdated
Show resolved
Hide resolved
...rs/StyleCop.Analyzers/LayoutRules/SA1519BracesMustNotBeOmittedFromMultiLineChildStatement.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1520UseBracesConsistently.cs
Outdated
Show resolved
Hide resolved
...p.Analyzers/StyleCop.Analyzers/NamingRules/SX1309SStaticFieldNamesMustBeginWithUnderscore.cs
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/SX1309FieldNamesMustBeginWithUnderscore.cs
Show resolved
Hide resolved
...Cop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1200UsingDirectivesMustBePlacedCorrectly.cs
Outdated
Show resolved
Hide resolved
...Cop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1200UsingDirectivesMustBePlacedCorrectly.cs
Outdated
Show resolved
Hide resolved
nxtn
force-pushed
the
resx
branch
3 times, most recently
from
298775d
to
2e7e9cd
Compare
sharwell
approved these changes
Sep 23, 2019
|
Thank you ! 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy reviewing 馃槈