Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple reprojections lose original vertices #1252

Conversation

sindizzy
Copy link
Contributor

@sindizzy sindizzy commented Dec 25, 2018

Reprojects all layers in the map frame so that they use new projection. Before they are reprojected the layers will get reloaded from the original source if available. This is useful when doing multiple reprojections on a layer as the reprojection will occur on the original vertices and not the reprojected vertices. For certain workflows multiple reprojections will tend to lose the original vertices and result in unexpected coordinates. This method attempts to alleviate the issue. This method also includes drawing layers, although they may lose their original vertices since they don't have a source from where we can reload.

Fixes #1104 and #782.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Before reprojection of a layer it is reloaded from the source (if available) so that the original vertices are always used as the main source.
  • This method also includes drawing layers, although they may lose their original vertices since they don't have a source from where we can reload.

Reprojects all layers in the map frame so that they use new projection. Before they are reprojected the layers will get reloaded from the original source if available. This is useful when doing multiple reprojections on a layer as the reprojection will occur on the original vertices and not the reprojected vertices. For certain workflows multiple reprojections will tend to lose the original vertices and result in unexpected coordinates. This method attempts to alleviate the issue. This method also includes drawing layers, although they may lose their original vertices since they don't have a source from where we can reload.
@sindizzy
Copy link
Contributor Author

This PR will be closed in lieu of the refactored PR here #1470

@sindizzy sindizzy closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant