Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An abstract base class for the data backends: DoubleMLBaseData #173

Merged
merged 12 commits into from Nov 15, 2022

Conversation

MalteKurz
Copy link
Member

@MalteKurz MalteKurz commented Nov 15, 2022

Description

This PR introduces a new abstract base class DoubleMLBaseData The goal is to disentangle the basic data handling, from the handling of the causal model (i.e. which variable is the treatment variable etc.).

Comments

The overall goal is to make it easier to write new data backends. Note however that the handling of the multiple treatment case is currently a pretty fundamental / core part of the implementation of the base class DoubleML. Therefore, it wasn't yet possible to completely get rid of properties like d_cols or n_treats in the base class DoubleMLBaseData.

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@MalteKurz MalteKurz marked this pull request as ready for review November 15, 2022 11:37
@MalteKurz MalteKurz changed the title A abstract base class for the data backends: DoubleMLBaseData An abstract base class for the data backends: DoubleMLBaseData Nov 15, 2022
@MalteKurz MalteKurz merged commit d786d58 into main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant