Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensitivity Analysis #201

Merged
merged 55 commits into from Jun 21, 2023
Merged

Add Sensitivity Analysis #201

merged 55 commits into from Jun 21, 2023

Conversation

SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented May 23, 2023

Description

Adding sensitivity analysis to account for omitted variable bias to PLR, IRM, DID and DIDCS models based on Chernozhukov et al. (2022).

Comments

  • started to move different checks into _utils_check folder

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

Comment on lines +109 to +112
# if not np.all(np.diff(train_index) > 0):
# raise NotImplementedError('Invalid sample split. Only sorted train indices are supported.')
# if not np.all(np.diff(test_index) > 0):
# raise NotImplementedError('Invalid sample split. Only sorted test indices are supported.')

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
doubleml/double_ml_did.py Fixed Show fixed Hide fixed
@@ -147,6 +147,8 @@
self._trimming_threshold = trimming_threshold
_check_trimming(self._trimming_rule, self._trimming_threshold)

self._sensitivity_implemented = True

Check warning

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute _sensitivity_implemented, which was previously defined in superclass
DoubleML
.
@@ -147,6 +147,8 @@
self._trimming_threshold = trimming_threshold
_check_trimming(self._trimming_rule, self._trimming_threshold)

self._sensitivity_implemented = True

Check warning

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute _sensitivity_implemented, which was previously defined in superclass
DoubleML
.
@SvenKlaassen SvenKlaassen changed the title Add Sensitivity Analysis to PLR and IRM Add Sensitivity Analysis Jun 12, 2023
@SvenKlaassen SvenKlaassen marked this pull request as ready for review June 15, 2023 14:53
@SvenKlaassen SvenKlaassen merged commit df617fd into main Jun 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant