Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings #224

Merged
merged 2 commits into from Dec 21, 2023
Merged

Add deprecation warnings #224

merged 2 commits into from Dec 21, 2023

Conversation

SvenKlaassen
Copy link
Member

Description

Adding deprication warnings for dml_procedure and apply_cross_fitting.
Both arguments will be removed from the DoubleML in the future. Instead dml2 will be the standard method and crossfitting is automatically applied.
To still use non crossfitted learners external_predictions can be used in fit().

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen merged commit 5d9a4c2 into main Dec 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant