Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add click hotspot for sorting #1031

Merged
merged 2 commits into from
Aug 23, 2022
Merged

style: Add click hotspot for sorting #1031

merged 2 commits into from
Aug 23, 2022

Conversation

YyumeiZhang
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • style: 增加排序的点击热区

🇺🇸 English

  • Fix: Add click hotspot for sorting

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

修改点:

  1. icon 的 size 由 small (1212)改为 default(1616);
  2. 当有 sorting 排序时, 排序的点击热区为包含title和sorting的区域( 此改动不影响完全自定义渲染)
    https://user-images.githubusercontent.com/101110131/183805746-99b48e77-f7a3-4bca-ad36-a9c4c2543b56.mp4

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88dd3a4:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #1031 (88dd3a4) into main (3de98e4) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   89.46%   89.20%   -0.27%     
==========================================
  Files         415      416       +1     
  Lines       22922    23108     +186     
  Branches     5763     5819      +56     
==========================================
+ Hits        20507    20613     +106     
- Misses       2415     2495      +80     
Impacted Files Coverage Δ
packages/semi-ui/table/ColumnFilter.tsx 77.61% <ø> (ø)
packages/semi-ui/table/ColumnSorter.tsx 90.90% <100.00%> (ø)
packages/semi-ui/table/Table.tsx 87.94% <100.00%> (ø)
packages/semi-foundation/select/foundation.ts 82.50% <0.00%> (-7.47%) ⬇️
packages/semi-foundation/tagInput/foundation.ts 83.62% <0.00%> (-5.04%) ⬇️
packages/semi-ui/select/index.tsx 91.52% <0.00%> (-2.45%) ⬇️
packages/semi-ui/progress/index.tsx 94.11% <0.00%> (-2.36%) ⬇️
packages/semi-ui/tagInput/index.tsx 87.87% <0.00%> (-1.60%) ⬇️
packages/semi-foundation/timePicker/foundation.ts 90.00% <0.00%> (-0.05%) ⬇️
packages/semi-ui/tag/index.tsx 96.92% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YyumeiZhang YyumeiZhang requested review from YannLynn and removed request for shijiatongxue and pointhalo August 18, 2022 05:48
@YyumeiZhang
Copy link
Collaborator Author

图标和文字的对齐方法https://zhuanlan.zhihu.com/p/30624268
origin_img_v2_39a26a90-e1f4-4025-9190-93124c8b12eg
@YannLynn

@YannLynn YannLynn merged commit 96c3ab9 into main Aug 23, 2022
@YannLynn YannLynn deleted the style/table-head-hotpot branch August 23, 2022 10:36
@pointhalo
Copy link
Collaborator

v 2.18.0-beta.0

DaiQiangReal pushed a commit that referenced this pull request Aug 25, 2022
* style: Add click hotspot for sorting

* fix: [Table] flter icon and title alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants